Issue 2480763003: Fix vr_shell shader not compiling on Samsung phones.

Issue 2480763003: Fix vr_shell shader not compiling on Samsung phones. (Closed)

Created:
4 years, 1 month ago by ostap

Modified:
4 years, 1 month ago

Reviewers:
mthiesse, bajones

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix vr_shell shader not compiling on Samsung phones. BUG=662534 Committed: https://crrev.com/1d6f92104c5044b1c9057a08980088e4f3b43b75 Cr-Commit-Position: refs/heads/master@{#430315}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/android/vr_shell/vr_shell_renderer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (3 generated)

bajones

Aw... seriously? LGTM, but needing to lowp ANYTHING in 2016 definitely does *not* look good ...

4 years, 1 month ago (2016-11-05 05:55:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480763003/1

4 years, 1 month ago (2016-11-07 17:43:56 UTC) #6

commit-bot: I haz the power

4 years, 1 month ago (2016-11-07 18:14:39 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1d6f92104c5044b1c9057a08980088e4f3b43b75
Cr-Commit-Position: refs/heads/master@{#430315}