Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2468263006:
Add UI_DEVTOOLS_EXPORT so tests can mock FrontendChannel (Closed)
|
Created:
4 years, 1 month ago by Sarmad Hashmi Modified:
4 years, 1 month ago Reviewers:
sadrul CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd UI_DEVTOOLS_EXPORT so tests can mock FrontendChannel
This change adds the UI_DEVTOOLS_EXPORT macro to the generated devtools
files. This is mainly so that FrontendChannel and UberDispatcher classes
are exposed to unit tests.
BUG=648701
Committed: https://crrev.com/f6541e95f3d06008a83f38fbfe77559448bdf985
Cr-Commit-Position: refs/heads/master@{#431442}
Patch Set 1 #Patch Set 2 : Add UI_DEVTOOLS_EXPORT so tests can mock FrontendChannel #Patch Set 3 : Add UI_DEVTOOLS_EXPORT so tests can mock FrontendChannel #
Total comments: 2
Patch Set 4 : Add to BUILD file #Patch Set 5 : Add to BUILD file #Patch Set 6 : Sync with master #
Messages
Total messages: 33 (23 generated)
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mhashmi@chromium.org changed reviewers: + sadrul@chromium.org
PTAL sadrul@
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The new UI_DEVTOOLS_EXPORT doesn't seem to be used in the code in three. Is it added/used in the generated code?
Yep, it's used in all the generated classes. Sorry, should've mentioned that!
lgtm https://codereview.chromium.org/2468263006/diff/40001/components/ui_devtools/... File components/ui_devtools/BUILD.gn (right): https://codereview.chromium.org/2468263006/diff/40001/components/ui_devtools/... components/ui_devtools/BUILD.gn:65: "switches.h", Add the _export.h file here too.
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
https://codereview.chromium.org/2468263006/diff/40001/components/ui_devtools/... File components/ui_devtools/BUILD.gn (right): https://codereview.chromium.org/2468263006/diff/40001/components/ui_devtools/... components/ui_devtools/BUILD.gn:65: "switches.h", On 2016/11/09 15:46:23, sadrul wrote: > Add the _export.h file here too. Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mhashmi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org Link to the patchset: https://codereview.chromium.org/2468263006/#ps60001 (title: "Add to BUILD file")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
The CQ bit was checked by mhashmi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org Link to the patchset: https://codereview.chromium.org/2468263006/#ps100001 (title: "Sync with master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Add UI_DEVTOOLS_EXPORT so tests can mock FrontendChannel This change adds the UI_DEVTOOLS_EXPORT macro to the generated devtools files. This is mainly so that FrontendChannel and UberDispatcher classes are exposed to unit tests. BUG=648701 ========== to ========== Add UI_DEVTOOLS_EXPORT so tests can mock FrontendChannel This change adds the UI_DEVTOOLS_EXPORT macro to the generated devtools files. This is mainly so that FrontendChannel and UberDispatcher classes are exposed to unit tests. BUG=648701 Committed: https://crrev.com/f6541e95f3d06008a83f38fbfe77559448bdf985 Cr-Commit-Position: refs/heads/master@{#431442} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/f6541e95f3d06008a83f38fbfe77559448bdf985 Cr-Commit-Position: refs/heads/master@{#431442} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
