MD Settings: Copy Import Bookmarks handler to MD Settings

MD Settings: Copy Import Bookmarks handler to MD Settings

Pretty much a verbatim copy with some Settings-specific modifications.

BUG=659259
Committed: https://crrev.com/bc3a1fed587712156737197e561a88f2ea0bfecc
Cr-Commit-Position: refs/heads/master@{#429754}

[tommycli, 2016-11-03 18:58:43]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 18:59:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-03 19:01:29]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 19:01:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-03 19:02:05]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-11-03 19:02:05]

dbeam: PTAL, thanks!

[Dan Beam, 2016-11-03 19:23:05]

lgtm

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_ui.cc (right):

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_ui.cc:81:
AddSettingsPageUIHandler(new ImportDataHandler());
this list looks like a drunk attempt at alphabetization.  oh well

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_import_data_handler.cc (right):

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_import_data_handler.cc:185:
web_ui()->CallJavascriptFunctionUnsafe(
i haz a sadz

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_import_data_handler.h (right):

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_import_data_handler.h:1: // Copyright
(c) 2012 The Chromium Authors. All rights reserved.
arguably 2016 and no (c)

[tommycli, 2016-11-03 19:29:39]

thanks!

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_ui.cc (right):

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_ui.cc:81:
AddSettingsPageUIHandler(new ImportDataHandler());
On 2016/11/03 19:23:05, Dan Beam wrote:
> this list looks like a drunk attempt at alphabetization.  oh well

Done. I made it slightly more alphabetized.

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_import_data_handler.cc (right):

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_import_data_handler.cc:185:
web_ui()->CallJavascriptFunctionUnsafe(
On 2016/11/03 19:23:05, Dan Beam wrote:
> i haz a sadz

Yeah I need to convert these to Promises, but I'm saving that for the same patch
as the browser proxy, so I know how it's structured exactly.

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_import_data_handler.h (right):

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_import_data_handler.h:1: // Copyright
(c) 2012 The Chromium Authors. All rights reserved.
On 2016/11/03 19:23:05, Dan Beam wrote:
> arguably 2016 and no (c)

Done.

[tommycli, 2016-11-03 19:29:42]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-11-03 19:29:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2480543002/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2016-11-03 19:30:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 22:15:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:15:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-11-03 22:59:32]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:00:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-03 23:06:09]

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/settings_import_data_handler.cc (right):

https://codereview.chromium.org/2480543002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/settings_import_data_handler.cc:185:
web_ui()->CallJavascriptFunctionUnsafe(
On 2016/11/03 19:29:38, tommycli wrote:
> On 2016/11/03 19:23:05, Dan Beam wrote:
> > i haz a sadz
> 
> Yeah I need to convert these to Promises, but I'm saving that for the same
patch
> as the browser proxy, so I know how it's structured exactly.

Followup is here: https://codereview.chromium.org/2473053004/

I gave that review to dpapad@ since he made the BrowserProxy stuff.

[commit-bot: I haz the power, 2016-11-04 01:20:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-04 01:22:06]

Description was changed from

==========
MD Settings: Copy Import Bookmarks handler to MD Settings

Pretty much a verbatim copy with some Settings-specific modifications.

BUG=659259
==========

to

==========
MD Settings: Copy Import Bookmarks handler to MD Settings

Pretty much a verbatim copy with some Settings-specific modifications.

BUG=659259

Committed: https://crrev.com/bc3a1fed587712156737197e561a88f2ea0bfecc
Cr-Commit-Position: refs/heads/master@{#429754}
==========

[commit-bot: I haz the power, 2016-11-04 01:22:07]

Patchset 5 (id:??) landed as
https://crrev.com/bc3a1fed587712156737197e561a88f2ea0bfecc
Cr-Commit-Position: refs/heads/master@{#429754}