MD Settings: Add an Import Data BrowserProxy.

MD Settings: Add an Import Data BrowserProxy.

This patch:
 a) Adds a BrowserProxy for the ImportDataHandler.
 b) Updates ImportDataHandler to use promises and WebUI events.

BUG=659259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4a4963ec66964b69df3c677384f6bcf51fe634dc
Cr-Commit-Position: refs/heads/master@{#429809}

[tommycli, 2016-11-03 21:59:47]

Description was changed from

==========
MD Settings: Add an Import Data BrowserProxy.

BUG=
==========

to

==========
MD Settings: Add an Import Data BrowserProxy.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-03 22:59:54]

Description was changed from

==========
MD Settings: Add an Import Data BrowserProxy.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add an Import Data BrowserProxy.

BUG=659259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-03 22:59:54]

tommycli@chromium.org changed reviewers:
+ dpapad@chromium.org

[tommycli, 2016-11-03 23:00:21]

Description was changed from

==========
MD Settings: Add an Import Data BrowserProxy.

BUG=659259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add an Import Data BrowserProxy.

This patch:
 a) Adds a BrowserProxy for the ImportDataHandler.
 b) Updates ImportDataHandler to use promises and WebUI events.

BUG=659259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-11-03 23:01:24]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[tommycli, 2016-11-03 23:01:35]

dpapad: PTAL, thanks!

[commit-bot: I haz the power, 2016-11-03 23:03:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-03 23:05:09]

On 2016/11/03 23:01:35, tommycli wrote:
> dpapad: PTAL, thanks!

FYI, I'm OOO starting tomorrow through next week. It's no problem if you can't
get to this today -- we can pick it up in a week. Just letting you know in case
you wonder why i don't respond to your comments tomorrow.

[dpapad, 2016-11-03 23:40:43]

LGTM with nits.

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/import_data_browser_proxy.js
(right):

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/import_data_browser_proxy.js:31:
IN_PROGRESS: 'inProgress',
Should these literals match the C++. If so let's add a comment saying so.

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/import_data_browser_proxy.js:42: *
Returns a true promise if Easy Unlock is already enabled on the device.
What's a true promise? Should it be Promise<boolean> or just the comment needs
to be rephrased?

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/settings_import_data_handler.cc (right):

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/settings_import_data_handler.cc:163: true,  //
include_interactive_profiles?
Maybe remove question mark at the end. Makes it sound like a TODO.

[tommycli, 2016-11-03 23:46:45]

dpapad: thank you!

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/import_data_browser_proxy.js
(right):

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/import_data_browser_proxy.js:31:
IN_PROGRESS: 'inProgress',
On 2016/11/03 23:40:43, dpapad wrote:
> Should these literals match the C++. If so let's add a comment saying so.

Done.

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/import_data_browser_proxy.js:42: *
Returns a true promise if Easy Unlock is already enabled on the device.
On 2016/11/03 23:40:43, dpapad wrote:
> What's a true promise? Should it be Promise<boolean> or just the comment needs
> to be rephrased?

Done. Oops, I just needed to update the comment.

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/settings_import_data_handler.cc (right):

https://codereview.chromium.org/2473053004/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/settings_import_data_handler.cc:163: true,  //
include_interactive_profiles?
On 2016/11/03 23:40:43, dpapad wrote:
> Maybe remove question mark at the end. Makes it sound like a TODO.

Done.

[tommycli, 2016-11-03 23:46:49]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-11-03 23:46:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2473053004/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-11-03 23:48:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:48:03]

This CL has an open dependency (Issue 2480543002 Patch 80001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[tommycli, 2016-11-04 00:57:55]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 00:58:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-11-04 01:24:50]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-11-04 01:24:50]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2016-11-04 04:28:53]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:29:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:10:47]

Description was changed from

==========
MD Settings: Add an Import Data BrowserProxy.

This patch:
 a) Adds a BrowserProxy for the ImportDataHandler.
 b) Updates ImportDataHandler to use promises and WebUI events.

BUG=659259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add an Import Data BrowserProxy.

This patch:
 a) Adds a BrowserProxy for the ImportDataHandler.
 b) Updates ImportDataHandler to use promises and WebUI events.

BUG=659259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-04 06:10:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-04 06:13:24]

Description was changed from

==========
MD Settings: Add an Import Data BrowserProxy.

This patch:
 a) Adds a BrowserProxy for the ImportDataHandler.
 b) Updates ImportDataHandler to use promises and WebUI events.

BUG=659259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add an Import Data BrowserProxy.

This patch:
 a) Adds a BrowserProxy for the ImportDataHandler.
 b) Updates ImportDataHandler to use promises and WebUI events.

BUG=659259
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4a4963ec66964b69df3c677384f6bcf51fe634dc
Cr-Commit-Position: refs/heads/master@{#429809}
==========

[commit-bot: I haz the power, 2016-11-04 06:13:25]

Patchset 2 (id:??) landed as
https://crrev.com/4a4963ec66964b69df3c677384f6bcf51fe634dc
Cr-Commit-Position: refs/heads/master@{#429809}