Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2480533002: Don't free non-tile resources on GPU rasterization toggle (Closed)

Created:
4 years, 1 month ago by ericrk
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Don't free non-tile resources on GPU rasterization toggle Currently we free all tree resources when GPU rasterization is toggled. This causes problems for non-tile resources as these resources: a) Are not impacted by GPU raster and don't need to be re-rasterized. b) Are not trivially re-creatable, leading to them disappearing. This change adds a new function ReleaseTileResources, which is used in place of ReleaseResources when only tile resources need to be freed. It also renames RecreateResources to RecreateTileResources, as we only implemented this function for picture layers. BUG=660929 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2468023002 Cr-Commit-Position: refs/heads/master@{#429354} (cherry picked from commit 7cedb549a0624a5a592bb592c1a828e52623fcb9) Committed: https://chromium.googlesource.com/chromium/src/+/64edcb17468821037530b22c903bdda22d179473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -73 lines) Patch
M cc/layers/layer_impl.h View 1 chunk +8 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +6 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 11 chunks +51 lines, -28 lines 0 comments Download
M cc/layers/texture_layer_impl_unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M cc/test/fake_picture_layer_impl.h View 2 chunks +10 lines, -6 lines 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 4 chunks +8 lines, -18 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +17 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ericrk
4 years, 1 month ago (2016-11-03 18:36:47 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
64edcb17468821037530b22c903bdda22d179473.

Powered by Google App Engine
This is Rietveld 408576698