Don't free non-tile resources on GPU rasterization toggle

Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new function ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

It also renames RecreateResources to RecreateTileResources, as we only
implemented this function for picture layers.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7cedb549a0624a5a592bb592c1a828e52623fcb9
Cr-Commit-Position: refs/heads/master@{#429354}

[ericrk, 2016-11-01 21:06:47]

Description was changed from

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new funciton ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

BUG=660929
==========

to

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new funciton ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ericrk, 2016-11-01 21:25:43]

Description was changed from

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new funciton ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new funciton ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

It also renames RecreateResources to RecreateTileResources, as we only
implemented this function for picture layers.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ericrk, 2016-11-01 21:28:24]

Description was changed from

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new funciton ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

It also renames RecreateResources to RecreateTileResources, as we only
implemented this function for picture layers.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new funciton ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

It also renames RecreateResources to RecreateTileResources, as we only
implemented this function for picture layers.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ericrk, 2016-11-01 21:28:38]

ericrk@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2016-11-01 22:47:04]

Description was changed from

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new funciton ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

It also renames RecreateResources to RecreateTileResources, as we only
implemented this function for picture layers.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new function ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

It also renames RecreateResources to RecreateTileResources, as we only
implemented this function for picture layers.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-11-01 22:47:10]

lgtm

[ericrk, 2016-11-02 00:20:32]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2016-11-02 00:21:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 01:03:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 01:03:25]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericrk, 2016-11-02 17:27:56]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-11-02 17:27:57]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2468023002/#ps60001
(title: "fix unittest")

[commit-bot: I haz the power, 2016-11-02 17:28:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 19:04:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-02 19:24:19]

Description was changed from

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new function ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

It also renames RecreateResources to RecreateTileResources, as we only
implemented this function for picture layers.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Don't free non-tile resources on GPU rasterization toggle

Currently we free all tree resources when GPU rasterization is toggled.
This causes problems for non-tile resources as these resources:
a) Are not impacted by GPU raster and don't need to be re-rasterized.
b) Are not trivially re-creatable, leading to them disappearing.

This change adds a new function ReleaseTileResources, which is used
in place of ReleaseResources when only tile resources need to be freed.

It also renames RecreateResources to RecreateTileResources, as we only
implemented this function for picture layers.

BUG=660929
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/7cedb549a0624a5a592bb592c1a828e52623fcb9
Cr-Commit-Position: refs/heads/master@{#429354}
==========

[commit-bot: I haz the power, 2016-11-02 19:24:20]

Patchset 4 (id:??) landed as
https://crrev.com/7cedb549a0624a5a592bb592c1a828e52623fcb9
Cr-Commit-Position: refs/heads/master@{#429354}