Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: ui/gl/init/gl_factory_mac.cc

Issue 2480373002: Refactor context creation parameters into a struct. (Closed)
Patch Set: address piman's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/init/gl_factory_mac.cc
diff --git a/ui/gl/init/gl_factory_mac.cc b/ui/gl/init/gl_factory_mac.cc
index 15c3b4c0b7e9a322ffdaf7e865f9e29599176f2c..243a7909b59e5ab9efa0e425a0a2079d6e55b868 100644
--- a/ui/gl/init/gl_factory_mac.cc
+++ b/ui/gl/init/gl_factory_mac.cc
@@ -70,7 +70,7 @@ bool GetGLWindowSystemBindingInfo(GLWindowSystemBindingInfo* info) {
scoped_refptr<GLContext> CreateGLContext(GLShareGroup* share_group,
GLSurface* compatible_surface,
- GpuPreference gpu_preference) {
+ const GLContextAttribs& attribs) {
TRACE_EVENT0("gpu", "gl::init::CreateGLContext");
switch (GetGLImplementation()) {
case kGLImplementationDesktopGL:
@@ -81,10 +81,10 @@ scoped_refptr<GLContext> CreateGLContext(GLShareGroup* share_group,
// always be creating the context with an offscreen surface first.
DCHECK(compatible_surface->IsOffscreen());
return InitializeGLContext(new GLContextCGL(share_group),
- compatible_surface, gpu_preference);
+ compatible_surface, attribs);
case kGLImplementationOSMesaGL:
return InitializeGLContext(new GLContextOSMesa(share_group),
- compatible_surface, gpu_preference);
+ compatible_surface, attribs);
case kGLImplementationMockGL:
return new GLContextStub(share_group);
default:

Powered by Google App Engine
This is Rietveld 408576698