Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: ui/gl/gl_context_wgl.cc

Issue 2480373002: Refactor context creation parameters into a struct. (Closed)
Patch Set: address piman's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_context_wgl.cc
diff --git a/ui/gl/gl_context_wgl.cc b/ui/gl/gl_context_wgl.cc
index 51b140b4907bc007216e60e19ed6a4d3d4e2e2f5..64b48b872536c30c3ed0948f7825c1871e3a5dd0 100644
--- a/ui/gl/gl_context_wgl.cc
+++ b/ui/gl/gl_context_wgl.cc
@@ -19,8 +19,13 @@ GLContextWGL::GLContextWGL(GLShareGroup* share_group)
: GLContextReal(share_group), context_(nullptr) {
}
-bool GLContextWGL::Initialize(
- GLSurface* compatible_surface, GpuPreference gpu_preference) {
+bool GLContextWGL::Initialize(GLSurface* compatible_surface,
+ const GLContextAttribs& attribs) {
+ // webgl_compatibility_context and disabling bind_generates_resource are not
+ // supported.
+ DCHECK(!attribs.webgl_compatibility_context &&
+ attribs.bind_generates_resource);
+
// Get the handle of another initialized context in the share group _before_
// setting context_. Otherwise this context will be considered initialized
// and could potentially be returned by GetHandle.

Powered by Google App Engine
This is Rietveld 408576698