Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: ui/gl/gl_context_glx.cc

Issue 2480373002: Refactor context creation parameters into a struct. (Closed)
Patch Set: address piman's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_context_glx.cc
diff --git a/ui/gl/gl_context_glx.cc b/ui/gl/gl_context_glx.cc
index ab81f5431f5240433ccd5aeca38e0db27cd86266..cae4242e044abaab2fd4e74e1714def1f2580756 100644
--- a/ui/gl/gl_context_glx.cc
+++ b/ui/gl/gl_context_glx.cc
@@ -159,8 +159,13 @@ XDisplay* GLContextGLX::display() {
return display_;
}
-bool GLContextGLX::Initialize(
- GLSurface* compatible_surface, GpuPreference gpu_preference) {
+bool GLContextGLX::Initialize(GLSurface* compatible_surface,
+ const GLContextAttribs& attribs) {
+ // webgl_compatibility_context and disabling bind_generates_resource are not
+ // supported.
+ DCHECK(!attribs.webgl_compatibility_context &&
+ attribs.bind_generates_resource);
+
display_ = static_cast<XDisplay*>(compatible_surface->GetDisplay());
GLXContext share_handle = static_cast<GLXContext>(

Powered by Google App Engine
This is Rietveld 408576698