Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/gl/gl_context_cgl.cc

Issue 2480373002: Refactor context creation parameters into a struct. (Closed)
Patch Set: address piman's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_context_cgl.cc
diff --git a/ui/gl/gl_context_cgl.cc b/ui/gl/gl_context_cgl.cc
index 8ad268996ab7fdd872df55cc891e9a036d34b673..2a105c4983d0fb1ee86e2e75ccf5336afbde3b44 100644
--- a/ui/gl/gl_context_cgl.cc
+++ b/ui/gl/gl_context_cgl.cc
@@ -91,11 +91,17 @@ GLContextCGL::GLContextCGL(GLShareGroup* share_group)
}
bool GLContextCGL::Initialize(GLSurface* compatible_surface,
- GpuPreference gpu_preference) {
+ const GLContextAttribs& attribs) {
DCHECK(compatible_surface);
- gpu_preference = ui::GpuSwitchingManager::GetInstance()->AdjustGpuPreference(
- gpu_preference);
+ // webgl_compatibility_context and disabling bind_generates_resource are not
+ // supported.
+ DCHECK(!attribs.webgl_compatibility_context &&
+ attribs.bind_generates_resource);
+
+ GpuPreference gpu_preference =
+ ui::GpuSwitchingManager::GetInstance()->AdjustGpuPreference(
+ attribs.gpu_preference);
GLContextCGL* share_context = share_group() ?
static_cast<GLContextCGL*>(share_group()->GetContext()) : nullptr;

Powered by Google App Engine
This is Rietveld 408576698