media/gpu/rendering_helper.cc - Issue 2480373002: Refactor context creation parameters into a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/rendering_helper.cc

Issue 2480373002: Refactor context creation parameters into a struct. (Closed)

Patch Set: address piman's comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/gpu/rendering_helper.cc

diff --git a/media/gpu/rendering_helper.cc b/media/gpu/rendering_helper.cc

index 959da7ce8c2c6ea02ee87e6b98ac0589d2e49894..0625ea61dfd38aaed52fbf220d94a281434dd464 100644

--- a/media/gpu/rendering_helper.cc

+++ b/media/gpu/rendering_helper.cc

@@ -350,7 +350,7 @@ void RenderingHelper::Initialize(const RenderingHelperParams& params,

screen_size_ = gl_surface_->GetSize();

gl_context_ = gl::init::CreateGLContext(nullptr, gl_surface_.get(),

- gl::PreferIntegratedGpu);

+ gl::GLContextAttribs());

CHECK(gl_context_->MakeCurrent(gl_surface_.get()));

CHECK_GT(params.window_sizes.size(), 0U);