Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2480323003: [Merge to 2883] Fix memory leaks in macOS Sierra for IME. (Closed)

Created:
4 years, 1 month ago by erikchen
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Merge to 2883] Fix memory leaks in macOS Sierra for IME. > The documentation for NSTextInputClient states that: > -selectedRange should return { NSNotFound, 0 } if there is no selection range. > -attributedSubstringForProposedRange:actualRange: must be able to handle > invalid ranges. > > The previous implementations in RenderWidgetHostViewCocoa failed to do either, > which results in catastrophic memory leaks on macOS Sierra during IME. In an > ASAN build, AppKit attempts to allocate ~2^64 bytes of memory. > > BUG=654695 > > Review-Url: https://codereview.chromium.org/2480893002 > Cr-Commit-Position: refs/heads/master@{#430116} > (cherry picked from commit 7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5) Committed: https://chromium.googlesource.com/chromium/src/+/da364879b2e82d42525cb8942c652c2403d43ffb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +23 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
erikchen
4 years, 1 month ago (2016-11-07 18:23:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da364879b2e82d42525cb8942c652c2403d43ffb.

Powered by Google App Engine
This is Rietveld 408576698