Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2480893002:
Fix incorrect implementation of NSTextInputClient. (Closed)
|
Created:
4 years, 1 month ago by erikchen Modified:
4 years, 1 month ago Reviewers:
Avi (use Gerrit) CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix incorrect implementation of NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either.
BUG=654695
Committed: https://crrev.com/1409990053e62bfbd6744d7f88524e0c0ee95797
Cr-Commit-Position: refs/heads/master@{#431945}
Patch Set 1 #Patch Set 2 : Add test. #Patch Set 3 : Fix -selectedRange to be able to return { N, 0 }. #
Total comments: 1
Patch Set 4 : Fix test. #
Messages
Total messages: 38 (23 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Fix RenderWidgetHostViewMac compliance with NSTextInputClient.
BUG=654695
==========
to
==========
Fix RenderWidgetHostViewMac compliance with NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations failed to do either, which results in catastrophic
memory leaks on macOS Sierra during IME. In an ASAN build, AppKit attempts to
allocate ~2^64 bytes of memory.
BUG=654695
==========
Description was changed from
==========
Fix RenderWidgetHostViewMac compliance with NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations failed to do either, which results in catastrophic
memory leaks on macOS Sierra during IME. In an ASAN build, AppKit attempts to
allocate ~2^64 bytes of memory.
BUG=654695
==========
to
==========
Fix memory leaks in macOS Sierra for IME.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either,
which results in catastrophic memory leaks on macOS Sierra during IME. In an
ASAN build, AppKit attempts to allocate ~2^64 bytes of memory.
BUG=654695
==========
erikchen@chromium.org changed reviewers: + avi@chromium.org
avi: Please review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm lgtm
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from
==========
Fix memory leaks in macOS Sierra for IME.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either,
which results in catastrophic memory leaks on macOS Sierra during IME. In an
ASAN build, AppKit attempts to allocate ~2^64 bytes of memory.
BUG=654695
==========
to
==========
Fix memory leaks in macOS Sierra for IME.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either,
which results in catastrophic memory leaks on macOS Sierra during IME. In an
ASAN build, AppKit attempts to allocate ~2^64 bytes of memory.
BUG=654695
Committed: https://crrev.com/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5
Cr-Commit-Position: refs/heads/master@{#430116}
==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5 Cr-Commit-Position: refs/heads/master@{#430116}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2497073002/ by erikchen@chromium.org. The reason for reverting is: Breaks some IME [hold down a vowel, English input language] without fully fixing IME issues on macOS Sierra. https://bugs.chromium.org/p/chromium/issues/detail?id=664554#c5.
Message was sent while issue was closed.
Description was changed from
==========
Fix memory leaks in macOS Sierra for IME.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either,
which results in catastrophic memory leaks on macOS Sierra during IME. In an
ASAN build, AppKit attempts to allocate ~2^64 bytes of memory.
BUG=654695
Committed: https://crrev.com/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5
Cr-Commit-Position: refs/heads/master@{#430116}
==========
to
==========
Fix memory leaks in macOS Sierra for IME.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either,
which results in catastrophic memory leaks on macOS Sierra during IME. In an
ASAN build, AppKit attempts to allocate ~2^64 bytes of memory.
BUG=654695
Committed: https://crrev.com/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5
Cr-Commit-Position: refs/heads/master@{#430116}
==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
avi: PTAL. Note the 1-line change between PS 2 and 3.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2480893002/diff/40001/content/browser/rendere... File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/2480893002/diff/40001/content/browser/rendere... content/browser/renderer_host/render_widget_host_view_mac.mm:3021: if (selectedRange_.location == NSNotFound) Oh. Oops.
Description was changed from
==========
Fix memory leaks in macOS Sierra for IME.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either,
which results in catastrophic memory leaks on macOS Sierra during IME. In an
ASAN build, AppKit attempts to allocate ~2^64 bytes of memory.
BUG=654695
Committed: https://crrev.com/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5
Cr-Commit-Position: refs/heads/master@{#430116}
==========
to
==========
Fix incorrect implementation of NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either.
BUG=654695
==========
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was checked by erikchen@chromium.org
Description was changed from
==========
Fix incorrect implementation of NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either.
BUG=654695
==========
to
==========
Fix incorrect implementation of NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either.
BUG=654695
==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org Link to the patchset: https://codereview.chromium.org/2480893002/#ps60001 (title: "Fix test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Fix incorrect implementation of NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either.
BUG=654695
==========
to
==========
Fix incorrect implementation of NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either.
BUG=654695
==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from
==========
Fix incorrect implementation of NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either.
BUG=654695
==========
to
==========
Fix incorrect implementation of NSTextInputClient.
The documentation for NSTextInputClient states that:
-selectedRange should return { NSNotFound, 0 } if there is no selection range.
-attributedSubstringForProposedRange:actualRange: must be able to handle
invalid ranges.
The previous implementations in RenderWidgetHostViewCocoa failed to do either.
BUG=654695
Committed: https://crrev.com/1409990053e62bfbd6744d7f88524e0c0ee95797
Cr-Commit-Position: refs/heads/master@{#431945}
==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/1409990053e62bfbd6744d7f88524e0c0ee95797 Cr-Commit-Position: refs/heads/master@{#431945} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
