Fix links in tutorial

chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
index 582574b19831a2cbdb37aeed62cf9d45b2d88c40..4b42c9f49807d56a542a3b6bcbdaa70a39bbd3f8 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js
@@ -178,7 +178,10 @@ Tutorial.prototype = {
         element = document.createElement('li');
       } else if (pageElement.link) {
         element = document.createElement('a');
-        element.href = pageElement.link;

[dmazzoni, 2016/11/07 23:55:35]

I think you should add href='#' or role="link" and tabIndex=0, because otherwise
technically an "a" element with no href isn't even a link

[David Tseng, 2016/11/08 02:47:24]

Strange it worked for me as I definitely moved to the links via search+l in
order to verify that they did indeed respond to click.

Anyway, converted to role link with tabindex 0 and new-style event listeners.

+        element.onclick = function() {

[dmazzoni, 2016/11/07 23:55:35]

return false, or stopPropagation/preventDefault?

[David Tseng, 2016/11/08 02:47:24]

Ok, explicitly returning false 

+          Panel.closeMenusAndRestoreFocus();
+          chrome.windows.create({url: pageElement.link});
+        };
         element.target = '_blank';
       } else {
         element = document.createElement('p');