Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3244)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

Issue 2480303003: Fix links in tutorial (Closed)
Patch Set: Piggybacking node.url check for images. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
index 9cda6fcc6539795a73411af4184b9f061ac35488..8d5a9574026d6bb4d9bc4e8ff6b62df7be52b422 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
@@ -301,6 +301,7 @@ AutomationPredicate.container = function(node) {
*/
AutomationPredicate.structuralContainer = AutomationPredicate.roles([
Role.rootWebArea,
+ Role.webView,
Role.embeddedObject,
Role.iframe,
Role.iframePresentational]);
@@ -345,8 +346,8 @@ AutomationPredicate.shouldIgnoreNode = function(node) {
if (node.role == Role.listMarker)
return true;
- // Don't ignore nodes with names.
- if (node.name || node.value || node.description)
+ // Don't ignore nodes with names or name-like attribute.
+ if (node.name || node.value || node.description || node.url)
return false;
// Ignore some roles.

Powered by Google App Engine
This is Rietveld 408576698