chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js - Issue 2480303003: Fix links in tutorial

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js

Issue 2480303003: Fix links in tutorial (Closed)

Patch Set: Fix links in tutorial Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js ('k') | chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js

index 582574b19831a2cbdb37aeed62cf9d45b2d88c40..123f9f24b61d9661486f0800327bdfe03b2c16e5 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/tutorial.js

@@ -179,7 +179,12 @@ Tutorial.prototype = {

} else if (pageElement.link) {

element = document.createElement('a');

element.href = pageElement.link;

- element.target = '_blank';

+ element.setAttribute('tabindex', 0);

+ element.addEventListener('click', function(evt) {

+ Panel.closeMenusAndRestoreFocus();

+ chrome.windows.create({url: evt.target.href});

+ return false;

+ }, false);

} else {

element = document.createElement('p');

}