Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
index 516e59a8d641c2cdfb41df6d8f017be8cdbd63cb..aae1df40b8a14f8fa27a78459ddb27facb7f11f2 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
@@ -17,6 +17,7 @@
#include "public/platform/modules/serviceworker/WebServiceWorkerProvider.h"
#include "wtf/PtrUtil.h"
#include <memory>
+#include <utility>
namespace blink {
@@ -98,7 +99,8 @@ ScriptPromise ServiceWorkerRegistration::update(ScriptState* scriptState) {
ScriptPromise promise = resolver->promise();
m_handle->registration()->update(
client->provider(),
- new CallbackPromiseAdapter<void, ServiceWorkerErrorForUpdate>(resolver));
+ WTF::makeUnique<
+ CallbackPromiseAdapter<void, ServiceWorkerErrorForUpdate>>(resolver));
return promise;
}
@@ -116,7 +118,8 @@ ScriptPromise ServiceWorkerRegistration::unregister(ScriptState* scriptState) {
ScriptPromise promise = resolver->promise();
m_handle->registration()->unregister(
client->provider(),
- new CallbackPromiseAdapter<bool, ServiceWorkerError>(resolver));
+ WTF::makeUnique<CallbackPromiseAdapter<bool, ServiceWorkerError>>(
+ resolver));
return promise;
}

Powered by Google App Engine
This is Rietveld 408576698