Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
index 355119cf2f1eb58bd8324ac3c741ad3959ffc875..be5112e3079ba1abc9a865fd69cfd856786d524f 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h
@@ -64,10 +64,12 @@ class MODULES_EXPORT ServiceWorkerGlobalScopeClient
// Called from ServiceWorkerClients.
virtual void getClient(const WebString&,
- WebServiceWorkerClientCallbacks*) = 0;
- virtual void getClients(const WebServiceWorkerClientQueryOptions&,
- WebServiceWorkerClientsCallbacks*) = 0;
- virtual void openWindow(const WebURL&, WebServiceWorkerClientCallbacks*) = 0;
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
+ virtual void getClients(
+ const WebServiceWorkerClientQueryOptions&,
+ std::unique_ptr<WebServiceWorkerClientsCallbacks>) = 0;
+ virtual void openWindow(const WebURL&,
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
virtual void setCachedMetadata(const WebURL&, const char*, size_t) = 0;
virtual void clearCachedMetadata(const WebURL&) = 0;
@@ -112,13 +114,15 @@ class MODULES_EXPORT ServiceWorkerGlobalScopeClient
const WebCrossOriginServiceWorkerClient&,
const WebString& message,
std::unique_ptr<WebMessagePortChannelArray>) = 0;
- virtual void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) = 0;
- virtual void claim(WebServiceWorkerClientsClaimCallbacks*) = 0;
+ virtual void skipWaiting(
+ std::unique_ptr<WebServiceWorkerSkipWaitingCallbacks>) = 0;
+ virtual void claim(
+ std::unique_ptr<WebServiceWorkerClientsClaimCallbacks>) = 0;
virtual void focus(const WebString& clientUUID,
- WebServiceWorkerClientCallbacks*) = 0;
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
virtual void navigate(const WebString& clientUUID,
const WebURL&,
- WebServiceWorkerClientCallbacks*) = 0;
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) = 0;
virtual void registerForeignFetchScopes(
const WebVector<WebURL>& subScopes,
const WebVector<WebSecurityOrigin>&) = 0;

Powered by Google App Engine
This is Rietveld 408576698