third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushManager.cpp ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

index 9bb93bddb318bb6f224a8f9750a23de089c47823..913605005981c3473771fcbf9a8d7be190a85466 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscription.cpp

@@ -64,7 +64,7 @@ ScriptPromise PushSubscription::unsubscribe(ScriptState* scriptState) {

webPushProvider->unsubscribe(

m_serviceWorkerRegistration->webRegistration(),

- new CallbackPromiseAdapter<bool, PushError>(resolver));

+ WTF::makeUnique<CallbackPromiseAdapter<bool, PushError>>(resolver));

return promise;

}