Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushManager.cpp

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
diff --git a/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp b/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
index 6af41a09008ab913a59a094630c046f4e829a3ac..02302d5930f9c0615df50c767bbf7d77af4c9390 100644
--- a/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
+++ b/third_party/WebKit/Source/modules/push_messaging/PushManager.cpp
@@ -71,11 +71,12 @@ ScriptPromise PushManager::subscribe(ScriptState* scriptState,
"Document is detached from window."));
PushController::clientFrom(document->frame())
.subscribe(m_registration->webRegistration(), webOptions,
- new PushSubscriptionCallbacks(resolver, m_registration));
+ WTF::makeUnique<PushSubscriptionCallbacks>(resolver,
+ m_registration));
} else {
pushProvider()->subscribe(
m_registration->webRegistration(), webOptions,
- new PushSubscriptionCallbacks(resolver, m_registration));
+ WTF::makeUnique<PushSubscriptionCallbacks>(resolver, m_registration));
}
return promise;
@@ -87,7 +88,7 @@ ScriptPromise PushManager::getSubscription(ScriptState* scriptState) {
pushProvider()->getSubscription(
m_registration->webRegistration(),
- new PushSubscriptionCallbacks(resolver, m_registration));
+ WTF::makeUnique<PushSubscriptionCallbacks>(resolver, m_registration));
return promise;
}
@@ -110,7 +111,7 @@ ScriptPromise PushManager::permissionState(
pushProvider()->getPermissionStatus(
m_registration->webRegistration(),
PushSubscriptionOptions::toWeb(options, exceptionState),
- new PushPermissionStatusCallbacks(resolver));
+ WTF::makeUnique<PushPermissionStatusCallbacks>(resolver));
return promise;
}

Powered by Google App Engine
This is Rietveld 408576698