content/renderer/screen_orientation/screen_orientation_dispatcher.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/screen_orientation_dispatcher.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/renderer_blink_platform_impl.cc ('k') | content/renderer/screen_orientation/screen_orientation_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/screen_orientation/screen_orientation_dispatcher.h

diff --git a/content/renderer/screen_orientation/screen_orientation_dispatcher.h b/content/renderer/screen_orientation/screen_orientation_dispatcher.h

index dc200c15a294706bcc85fe72091b8ee5101c7a3f..21d31f5feea76c4083f0e756753dcb31ecaab566 100644

--- a/content/renderer/screen_orientation/screen_orientation_dispatcher.h

+++ b/content/renderer/screen_orientation/screen_orientation_dispatcher.h

@@ -5,6 +5,9 @@

#ifndef CONTENT_RENDERER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_DISPATCHER_H_

#define CONTENT_RENDERER_SCREEN_ORIENTATION_SCREEN_ORIENTATION_DISPATCHER_H_

+#include <memory>

+#include <utility>

#include "base/compiler_specific.h"

#include "base/id_map.h"

#include "base/macros.h"

@@ -40,8 +43,9 @@ class CONTENT_EXPORT ScreenOrientationDispatcher :

void OnDestruct() override;

// blink::WebScreenOrientationClient implementation.

- void lockOrientation(blink::WebScreenOrientationLockType orientation,

- blink::WebLockOrientationCallback* callback) override;

+ void lockOrientation(

+ blink::WebScreenOrientationLockType orientation,

+ std::unique_ptr<blink::WebLockOrientationCallback> callback) override;

void unlockOrientation() override;

void OnLockOrientationResult(int request_id,