content/renderer/screen_orientation/screen_orientation_dispatcher.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/screen_orientation/screen_orientation_dispatcher.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/screen_orientation/screen_orientation_dispatcher.h ('k') | content/renderer/screen_orientation/screen_orientation_dispatcher_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/screen_orientation/screen_orientation_dispatcher.cc

diff --git a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

index 2b6a41feba071862301c53a5cd0af059a22ca6fa..bcac89d3b8e7415e70145032aab29c012e20790b 100644

--- a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

+++ b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc

@@ -65,10 +65,10 @@ void ScreenOrientationDispatcher::CancelPendingLocks() {

void ScreenOrientationDispatcher::lockOrientation(

blink::WebScreenOrientationLockType orientation,

- blink::WebLockOrientationCallback* callback) {

+ std::unique_ptr<blink::WebLockOrientationCallback> callback) {

CancelPendingLocks();

- int request_id = pending_callbacks_.Add(callback);

+ int request_id = pending_callbacks_.Add(std::move(callback));

EnsureScreenOrientationService();

screen_orientation_->LockOrientation(

orientation,