content/renderer/presentation/presentation_dispatcher.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/presentation/presentation_dispatcher.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/cache_storage/webserviceworkercachestorage_impl.cc ('k') | content/renderer/presentation/presentation_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/presentation/presentation_dispatcher.h

diff --git a/content/renderer/presentation/presentation_dispatcher.h b/content/renderer/presentation/presentation_dispatcher.h

index 057a91d584802d96f8127e59eee5121f9cc372db..86cc679f22ad1d3f7634a0db8c222804930c2971 100644

--- a/content/renderer/presentation/presentation_dispatcher.h

+++ b/content/renderer/presentation/presentation_dispatcher.h

@@ -70,11 +70,13 @@ class CONTENT_EXPORT PresentationDispatcher

void startSession(

const blink::WebVector<blink::WebURL>& presentationUrls,

- blink::WebPresentationConnectionClientCallbacks* callback) override;

+ std::unique_ptr<blink::WebPresentationConnectionClientCallbacks> callback)

+ override;

void joinSession(

const blink::WebVector<blink::WebURL>& presentationUrls,

const blink::WebString& presentationId,

- blink::WebPresentationConnectionClientCallbacks* callback) override;

+ std::unique_ptr<blink::WebPresentationConnectionClientCallbacks> callback)

+ override;

void sendString(const blink::WebURL& presentationUrl,

const blink::WebString& presentationId,

const blink::WebString& message) override;

@@ -92,7 +94,8 @@ class CONTENT_EXPORT PresentationDispatcher

const blink::WebString& presentationId) override;

void getAvailability(

const blink::WebURL& availabilityUrl,

- blink::WebPresentationAvailabilityCallbacks* callbacks) override;

+ std::unique_ptr<blink::WebPresentationAvailabilityCallbacks> callbacks)

+ override;

void startListening(blink::WebPresentationAvailabilityObserver*) override;

void stopListening(blink::WebPresentationAvailabilityObserver*) override;

void setDefaultPresentationUrls(

@@ -121,7 +124,7 @@ class CONTENT_EXPORT PresentationDispatcher

blink::mojom::PresentationSessionInfoPtr session_info) override;

void OnSessionCreated(

- blink::WebPresentationConnectionClientCallbacks* callback,

+ std::unique_ptr<blink::WebPresentationConnectionClientCallbacks> callback,

blink::mojom::PresentationSessionInfoPtr session_info,

blink::mojom::PresentationErrorPtr error);

void OnReceiverConnectionAvailable(