Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: content/renderer/cache_storage/webserviceworkercachestorage_impl.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/cache_storage/webserviceworkercachestorage_impl.cc
diff --git a/content/renderer/cache_storage/webserviceworkercachestorage_impl.cc b/content/renderer/cache_storage/webserviceworkercachestorage_impl.cc
index 2103c9cd21bc02c0247e37f1b7bb4dc4c9908235..0e706f28f5ac03c56cd3eee290d0d23174136d81 100644
--- a/content/renderer/cache_storage/webserviceworkercachestorage_impl.cc
+++ b/content/renderer/cache_storage/webserviceworkercachestorage_impl.cc
@@ -4,6 +4,9 @@
#include "content/renderer/cache_storage/webserviceworkercachestorage_impl.h"
+#include <memory>
+#include <utility>
+
#include "content/child/thread_safe_sender.h"
#include "content/renderer/cache_storage/cache_storage_dispatcher.h"
#include "third_party/WebKit/public/platform/WebHTTPHeaderVisitor.h"
@@ -24,33 +27,34 @@ WebServiceWorkerCacheStorageImpl::~WebServiceWorkerCacheStorageImpl() {
}
void WebServiceWorkerCacheStorageImpl::dispatchHas(
- CacheStorageCallbacks* callbacks,
+ std::unique_ptr<CacheStorageCallbacks> callbacks,
const blink::WebString& cacheName) {
- GetDispatcher()->dispatchHas(callbacks, origin_, cacheName);
+ GetDispatcher()->dispatchHas(std::move(callbacks), origin_, cacheName);
}
void WebServiceWorkerCacheStorageImpl::dispatchOpen(
- CacheStorageWithCacheCallbacks* callbacks,
+ std::unique_ptr<CacheStorageWithCacheCallbacks> callbacks,
const blink::WebString& cacheName) {
- GetDispatcher()->dispatchOpen(callbacks, origin_, cacheName);
+ GetDispatcher()->dispatchOpen(std::move(callbacks), origin_, cacheName);
}
void WebServiceWorkerCacheStorageImpl::dispatchDelete(
- CacheStorageCallbacks* callbacks,
+ std::unique_ptr<CacheStorageCallbacks> callbacks,
const blink::WebString& cacheName) {
- GetDispatcher()->dispatchDelete(callbacks, origin_, cacheName);
+ GetDispatcher()->dispatchDelete(std::move(callbacks), origin_, cacheName);
}
void WebServiceWorkerCacheStorageImpl::dispatchKeys(
- CacheStorageKeysCallbacks* callbacks) {
- GetDispatcher()->dispatchKeys(callbacks, origin_);
+ std::unique_ptr<CacheStorageKeysCallbacks> callbacks) {
+ GetDispatcher()->dispatchKeys(std::move(callbacks), origin_);
}
void WebServiceWorkerCacheStorageImpl::dispatchMatch(
- CacheStorageMatchCallbacks* callbacks,
+ std::unique_ptr<CacheStorageMatchCallbacks> callbacks,
const blink::WebServiceWorkerRequest& request,
const blink::WebServiceWorkerCache::QueryParams& query_params) {
- GetDispatcher()->dispatchMatch(callbacks, origin_, request, query_params);
+ GetDispatcher()->dispatchMatch(std::move(callbacks), origin_, request,
+ query_params);
}
CacheStorageDispatcher* WebServiceWorkerCacheStorageImpl::GetDispatcher()

Powered by Google App Engine
This is Rietveld 408576698