third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp ('K') | « third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerProvider.h ('k') | third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h » ('j') | third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

diff --git a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

index d2f45a960bfdcf9dd1e199347e68b7a1b2e75573..0b13296bb6e6998f592369c4f581b115d2fc1618 100644

--- a/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

+++ b/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

@@ -8,6 +8,8 @@

#include "public/platform/WebCallbacks.h"

#include "public/platform/WebURL.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerError.h"

+#include <memory>

+#include <utility>

danakj 2016/11/30 00:34:01 no utility needed here this file doesnt use move()

namespace blink {

@@ -52,9 +54,10 @@ class WebServiceWorkerRegistration {

virtual WebURL scope() const { return WebURL(); }

virtual int64_t registrationId() const = 0;

virtual void update(WebServiceWorkerProvider*,

- WebServiceWorkerUpdateCallbacks*) {}

- virtual void unregister(WebServiceWorkerProvider*,

- WebServiceWorkerUnregistrationCallbacks*) {}

+ std::unique_ptr<WebServiceWorkerUpdateCallbacks>) {}

+ virtual void unregister(

+ WebServiceWorkerProvider*,

+ std::unique_ptr<WebServiceWorkerUnregistrationCallbacks>) {}

virtual void enableNavigationPreload(

bool enable,