Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Side by Side Diff: third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebServiceWorkerRegistration_h 5 #ifndef WebServiceWorkerRegistration_h
6 #define WebServiceWorkerRegistration_h 6 #define WebServiceWorkerRegistration_h
7 7
8 #include "public/platform/WebCallbacks.h" 8 #include "public/platform/WebCallbacks.h"
9 #include "public/platform/WebURL.h" 9 #include "public/platform/WebURL.h"
10 #include "public/platform/modules/serviceworker/WebServiceWorkerError.h" 10 #include "public/platform/modules/serviceworker/WebServiceWorkerError.h"
11 #include <memory>
12 #include <utility>
danakj 2016/11/30 00:34:01 no utility needed here this file doesnt use move()
11 13
12 namespace blink { 14 namespace blink {
13 15
14 class WebServiceWorkerProvider; 16 class WebServiceWorkerProvider;
15 class WebServiceWorkerRegistrationProxy; 17 class WebServiceWorkerRegistrationProxy;
16 struct WebNavigationPreloadState; 18 struct WebNavigationPreloadState;
17 19
18 // The interface of the registration representation in the embedder. The 20 // The interface of the registration representation in the embedder. The
19 // embedder implements this interface and passes its handle 21 // embedder implements this interface and passes its handle
20 // (WebServiceWorkerRegistration::Handle) to Blink. Blink accesses the 22 // (WebServiceWorkerRegistration::Handle) to Blink. Blink accesses the
(...skipping 24 matching lines...) Expand all
45 virtual WebServiceWorkerRegistration* registration() { return nullptr; } 47 virtual WebServiceWorkerRegistration* registration() { return nullptr; }
46 }; 48 };
47 49
48 virtual void setProxy(WebServiceWorkerRegistrationProxy*) {} 50 virtual void setProxy(WebServiceWorkerRegistrationProxy*) {}
49 virtual WebServiceWorkerRegistrationProxy* proxy() { return nullptr; } 51 virtual WebServiceWorkerRegistrationProxy* proxy() { return nullptr; }
50 virtual void proxyStopped() {} 52 virtual void proxyStopped() {}
51 53
52 virtual WebURL scope() const { return WebURL(); } 54 virtual WebURL scope() const { return WebURL(); }
53 virtual int64_t registrationId() const = 0; 55 virtual int64_t registrationId() const = 0;
54 virtual void update(WebServiceWorkerProvider*, 56 virtual void update(WebServiceWorkerProvider*,
55 WebServiceWorkerUpdateCallbacks*) {} 57 std::unique_ptr<WebServiceWorkerUpdateCallbacks>) {}
56 virtual void unregister(WebServiceWorkerProvider*, 58 virtual void unregister(
57 WebServiceWorkerUnregistrationCallbacks*) {} 59 WebServiceWorkerProvider*,
60 std::unique_ptr<WebServiceWorkerUnregistrationCallbacks>) {}
58 61
59 virtual void enableNavigationPreload( 62 virtual void enableNavigationPreload(
60 bool enable, 63 bool enable,
61 WebServiceWorkerProvider*, 64 WebServiceWorkerProvider*,
62 std::unique_ptr<WebEnableNavigationPreloadCallbacks>) {} 65 std::unique_ptr<WebEnableNavigationPreloadCallbacks>) {}
63 virtual void getNavigationPreloadState( 66 virtual void getNavigationPreloadState(
64 WebServiceWorkerProvider*, 67 WebServiceWorkerProvider*,
65 std::unique_ptr<WebGetNavigationPreloadStateCallbacks>) {} 68 std::unique_ptr<WebGetNavigationPreloadStateCallbacks>) {}
66 virtual void setNavigationPreloadHeader( 69 virtual void setNavigationPreloadHeader(
67 const WebString& value, 70 const WebString& value,
68 WebServiceWorkerProvider*, 71 WebServiceWorkerProvider*,
69 std::unique_ptr<WebSetNavigationPreloadHeaderCallbacks>) {} 72 std::unique_ptr<WebSetNavigationPreloadHeaderCallbacks>) {}
70 }; 73 };
71 74
72 } // namespace blink 75 } // namespace blink
73 76
74 #endif // WebServiceWorkerRegistration_h 77 #endif // WebServiceWorkerRegistration_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698