content/renderer/service_worker/embedded_worker_dispatcher.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_dispatcher.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/service_worker/embedded_worker_dispatcher.cc

diff --git a/content/renderer/service_worker/embedded_worker_dispatcher.cc b/content/renderer/service_worker/embedded_worker_dispatcher.cc

index e68ad202d2f76ce5e016616d9b44bcddf6a7a5a6..c3caf1541d87fa63f3654e252b66e390c6532104 100644

--- a/content/renderer/service_worker/embedded_worker_dispatcher.cc

+++ b/content/renderer/service_worker/embedded_worker_dispatcher.cc

@@ -157,7 +157,7 @@ EmbeddedWorkerDispatcher::StartWorkerContext(

void EmbeddedWorkerDispatcher::RegisterWorker(

int embedded_worker_id,

std::unique_ptr<WorkerWrapper> wrapper) {

- workers_.AddWithID(wrapper.release(), embedded_worker_id);

+ workers_.AddWithID(std::move(wrapper), embedded_worker_id);

}

void EmbeddedWorkerDispatcher::UnregisterWorker(int embedded_worker_id) {