Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

content/renderer/screen_orientation/screen_orientation_dispatcher.cc

Index: content/renderer/screen_orientation/screen_orientation_dispatcher.cc
diff --git a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc
index 5f2071d377945cab190ed1bfd71ddf2da976e616..a5ba0536728632444290c8faa392386234825f12 100644
--- a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc
+++ b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc
@@ -4,6 +4,8 @@
 
 #include "content/renderer/screen_orientation/screen_orientation_dispatcher.h"
 
+#include <memory>
+
 #include "content/common/screen_orientation_messages.h"
 
 namespace content {
@@ -67,7 +69,8 @@ void ScreenOrientationDispatcher::lockOrientation(
     blink::WebLockOrientationCallback* callback) {

[danakj, 2016/11/18 00:15:33]

same

[rlanday, 2016/11/22 18:22:33]

There's a unit test that creates something called a MockLockOrientationCallback
which has a private destructor, making it not work with unique_ptr:
https://cs.chromium.org/chromium/src/content/renderer/screen_orientation/scre...

I'm afraid to change it because I'm not sure how it works.

[rlanday, 2016/11/22 19:08:04]

note: I ended up just making the destructor public here, I assume it doesn't
really change anything since it's only used in the test case...

   CancelPendingLocks();
 
-  int request_id = pending_callbacks_.Add(callback);
+  int request_id = pending_callbacks_.Add(
+      std::unique_ptr<blink::WebLockOrientationCallback>(callback));
   Send(new ScreenOrientationHostMsg_LockRequest(
       routing_id(), orientation, request_id));
 }