chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

diff --git a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

index ba693e6f91fc8feaaf1c8914aed50b620f2efea5..b3ea5ef62518560147df19788857b102f3dae93b 100644

--- a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

+++ b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc

@@ -107,7 +107,8 @@ void PopupBlockerTabHelper::AddBlockedPopup(

if (blocked_popups_.size() >= kMaximumNumberOfPopups)

return;

- blocked_popups_.Add(new BlockedRequest(params, window_features));

+ blocked_popups_.Add(

+ base::MakeUnique<BlockedRequest>(params, window_features));

TabSpecificContentSettings::FromWebContents(web_contents())->

OnContentBlocked(CONTENT_SETTINGS_TYPE_POPUPS);

}