chrome/browser/metrics/subprocess_metrics_provider.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/subprocess_metrics_provider.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/subprocess_metrics_provider.cc

diff --git a/chrome/browser/metrics/subprocess_metrics_provider.cc b/chrome/browser/metrics/subprocess_metrics_provider.cc

index 06d255350adeb91f8c594192be5dd1689f8b7743..2a58b7d39e98909b5f79d4d3c55d3d759e15e81b 100644

--- a/chrome/browser/metrics/subprocess_metrics_provider.cc

+++ b/chrome/browser/metrics/subprocess_metrics_provider.cc

@@ -59,7 +59,7 @@ void SubprocessMetricsProvider::RegisterSubprocessAllocator(

return;

// Map is "MapOwnPointer" so transfer ownership to it.

- allocators_by_id_.AddWithID(allocator.release(), id);

+ allocators_by_id_.AddWithID(std::move(allocator), id);

}

void SubprocessMetricsProvider::DeregisterSubprocessAllocator(int id) {