Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2480233003: Fold DataProviders into parent classes (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fold DataProviders into parent classes This CL removes the data provider classes and folds the code into the parent classes. Committed: https://pdfium.googlesource.com/pdfium/+/eb3f68cc7f25a1e28464eb251161b8f08fcd04bc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+527 lines, -642 lines) Patch
M xfa/fwl/core/cfwl_barcode.h View 1 2 chunks +34 lines, -43 lines 0 comments Download
M xfa/fwl/core/cfwl_barcode.cpp View 3 chunks +59 lines, -48 lines 0 comments Download
M xfa/fwl/core/cfwl_checkbox.h View 1 2 chunks +9 lines, -16 lines 0 comments Download
M xfa/fwl/core/cfwl_checkbox.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.h View 1 2 chunks +64 lines, -75 lines 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 10 chunks +61 lines, -75 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.h View 1 2 chunks +16 lines, -22 lines 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 4 chunks +11 lines, -19 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.h View 1 2 chunks +60 lines, -70 lines 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 8 chunks +59 lines, -68 lines 0 comments Download
M xfa/fwl/core/cfwl_picturebox.h View 1 2 chunks +23 lines, -30 lines 0 comments Download
M xfa/fwl/core/cfwl_picturebox.cpp View 3 chunks +33 lines, -39 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.h View 1 2 chunks +9 lines, -16 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.cpp View 2 chunks +10 lines, -11 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 1 2 chunks +16 lines, -4 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 2 chunks +29 lines, -53 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.h View 1 4 chunks +13 lines, -19 lines 0 comments Download
M xfa/fwl/core/ifwl_datetimepicker.cpp View 1 5 chunks +13 lines, -23 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dsinclair
PTAL.
4 years, 1 month ago (2016-11-07 17:52:23 UTC) #2
Tom Sepez
https://codereview.chromium.org/2480233003/diff/1/xfa/fwl/core/cfwl_barcode.h File xfa/fwl/core/cfwl_barcode.h (right): https://codereview.chromium.org/2480233003/diff/1/xfa/fwl/core/cfwl_barcode.h#newcode39 xfa/fwl/core/cfwl_barcode.h:39: protected: I'd expect the overrides to be public since ...
4 years, 1 month ago (2016-11-07 18:00:20 UTC) #5
dsinclair
https://codereview.chromium.org/2480233003/diff/1/xfa/fwl/core/cfwl_barcode.h File xfa/fwl/core/cfwl_barcode.h (right): https://codereview.chromium.org/2480233003/diff/1/xfa/fwl/core/cfwl_barcode.h#newcode39 xfa/fwl/core/cfwl_barcode.h:39: protected: On 2016/11/07 18:00:20, Tom Sepez wrote: > I'd ...
4 years, 1 month ago (2016-11-07 18:14:23 UTC) #9
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-07 18:15:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480233003/20001
4 years, 1 month ago (2016-11-07 18:17:39 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 18:28:53 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/eb3f68cc7f25a1e28464eb251161b8f08fcd...

Powered by Google App Engine
This is Rietveld 408576698