Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: xfa/fwl/core/cfwl_checkbox.cpp

Issue 2480233003: Fold DataProviders into parent classes (Closed)
Patch Set: Review feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/core/cfwl_checkbox.h ('k') | xfa/fwl/core/cfwl_combobox.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/core/cfwl_checkbox.h" 7 #include "xfa/fwl/core/cfwl_checkbox.h"
8 8
9 #include <memory> 9 #include <memory>
10 10
11 #include "third_party/base/ptr_util.h" 11 #include "third_party/base/ptr_util.h"
12 #include "xfa/fwl/core/fwl_error.h" 12 #include "xfa/fwl/core/fwl_error.h"
13 13
14 namespace { 14 namespace {
15 15
16 IFWL_CheckBox* ToCheckBox(IFWL_Widget* widget) { 16 IFWL_CheckBox* ToCheckBox(IFWL_Widget* widget) {
17 return static_cast<IFWL_CheckBox*>(widget); 17 return static_cast<IFWL_CheckBox*>(widget);
18 } 18 }
19 19
20 } // namespace 20 } // namespace
21 21
22 CFWL_CheckBox::CFWL_CheckBox(const IFWL_App* app) : CFWL_Widget(app) {} 22 CFWL_CheckBox::CFWL_CheckBox(const IFWL_App* app)
23 : CFWL_Widget(app), m_fBoxHeight(16.0f), m_wsCaption(L"Check box") {}
23 24
24 CFWL_CheckBox::~CFWL_CheckBox() {} 25 CFWL_CheckBox::~CFWL_CheckBox() {}
25 26
26 void CFWL_CheckBox::Initialize() { 27 void CFWL_CheckBox::Initialize() {
27 ASSERT(!m_pIface); 28 ASSERT(!m_pIface);
28 29
29 m_pIface = pdfium::MakeUnique<IFWL_CheckBox>( 30 m_pIface = pdfium::MakeUnique<IFWL_CheckBox>(
30 m_pApp, pdfium::MakeUnique<CFWL_WidgetProperties>(&m_checkboxData)); 31 m_pApp, pdfium::MakeUnique<CFWL_WidgetProperties>(this));
31 32
32 CFWL_Widget::Initialize(); 33 CFWL_Widget::Initialize();
33 } 34 }
34 35
35 FWL_Error CFWL_CheckBox::SetCaption(const CFX_WideStringC& wsCaption) { 36 FWL_Error CFWL_CheckBox::SetCaption(const CFX_WideStringC& wsCaption) {
36 m_checkboxData.m_wsCaption = wsCaption; 37 m_wsCaption = wsCaption;
37 return FWL_Error::Succeeded; 38 return FWL_Error::Succeeded;
38 } 39 }
39 40
40 FWL_Error CFWL_CheckBox::SetBoxSize(FX_FLOAT fHeight) { 41 FWL_Error CFWL_CheckBox::SetBoxSize(FX_FLOAT fHeight) {
41 m_checkboxData.m_fBoxHeight = fHeight; 42 m_fBoxHeight = fHeight;
42 return FWL_Error::Succeeded; 43 return FWL_Error::Succeeded;
43 } 44 }
44 45
45 int32_t CFWL_CheckBox::GetCheckState() { 46 int32_t CFWL_CheckBox::GetCheckState() {
46 return ToCheckBox(GetWidget())->GetCheckState(); 47 return ToCheckBox(GetWidget())->GetCheckState();
47 } 48 }
48 49
49 FWL_Error CFWL_CheckBox::SetCheckState(int32_t iCheck) { 50 FWL_Error CFWL_CheckBox::SetCheckState(int32_t iCheck) {
50 return ToCheckBox(GetWidget())->SetCheckState(iCheck); 51 return ToCheckBox(GetWidget())->SetCheckState(iCheck);
51 } 52 }
52 53
53 CFWL_CheckBox::CFWL_CheckBoxDP::CFWL_CheckBoxDP() 54 FWL_Error CFWL_CheckBox::GetCaption(IFWL_Widget* pWidget,
54 : m_fBoxHeight(16.0f), m_wsCaption(L"Check box") {} 55 CFX_WideString& wsCaption) {
55
56 FWL_Error CFWL_CheckBox::CFWL_CheckBoxDP::GetCaption(
57 IFWL_Widget* pWidget,
58 CFX_WideString& wsCaption) {
59 wsCaption = m_wsCaption; 56 wsCaption = m_wsCaption;
60 return FWL_Error::Succeeded; 57 return FWL_Error::Succeeded;
61 } 58 }
62 59
63 FX_FLOAT CFWL_CheckBox::CFWL_CheckBoxDP::GetBoxSize(IFWL_Widget* pWidget) { 60 FX_FLOAT CFWL_CheckBox::GetBoxSize(IFWL_Widget* pWidget) {
64 return m_fBoxHeight; 61 return m_fBoxHeight;
65 } 62 }
OLDNEW
« no previous file with comments | « xfa/fwl/core/cfwl_checkbox.h ('k') | xfa/fwl/core/cfwl_combobox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698