Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2480223002: [debugger] Migrate more debugger tests to inspector (Closed)

Created:
4 years, 1 month ago by jgruber
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Migrate more debugger tests to inspector This moves all tests currently working with the inspector debugger wrapper to test/debugger. BUG=v8:5530 Committed: https://crrev.com/60d60fd716033ad47715019393195a12b19642c6 Cr-Commit-Position: refs/heads/master@{#40824}

Patch Set 1 #

Patch Set 2 : Don't move base file for test series #

Patch Set 3 : Revert failing async tests and migrate .status annotation #

Patch Set 4 : And remove failing async tests from debugger/ #

Patch Set 5 : Fix status line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2731 lines) Patch
A + test/debugger/debug/compiler/osr-typing-debug-change.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-break-default-constructor.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-promises/async-task-event.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-promises/evaluate-across-microtasks.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-promises/stepin-constructor.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-step-destructuring-assignment.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-step-destructuring-bind.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-step-into-class-extends.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-step-into-constructor.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-step-into-regexp-subclass.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-stepin-collections-foreach.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-stepin-generators.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-stepin-tailcalls.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/es6/debug-stepout-tailcalls.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/es6/generators-relocation.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/for-in-opt.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/harmony/async-debug-basic.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/debugger/debug/harmony/async-debug-step-abort-at-break.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/harmony/async-debug-step-in-out-out.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/harmony/async-debug-step-out.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/harmony/debug-async-break.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/debugger/debug/harmony/debug-async-break-on-stack.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/debugger/debug/ignition/debug-break.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/ignition/debug-break-on-stack.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/ignition/debug-scope-on-return.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/ignition/debugger-statement.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/regress/debug-prepare-step-in.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-147497.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-1523.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-269.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-2825.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-3717.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-392114.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-4320.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-491536.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-514362.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-5279.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-5559.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-617882.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/debugger/debug/regress/regress-94873.js View 1 chunk +0 lines, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-crbug-387599.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-405491.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/debugger/debug/regress/regress-crbug-405922.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-409614.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-568477-1.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-568477-3.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-568477-4.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-crbug-582048.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/regress/regress-debug-code-recompilation.js View 1 chunk +1 line, -2 lines 0 comments Download
A + test/debugger/debug/regress/regress-debug-context-load.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/debugger/debug/wasm/asm-debug.js View 1 chunk +1 line, -1 line 0 comments Download
M test/debugger/debugger.status View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download
D test/mjsunit/compiler/osr-typing-debug-change.js View 1 chunk +0 lines, -119 lines 0 comments Download
D test/mjsunit/es6/debug-break-default-constructor.js View 1 chunk +0 lines, -42 lines 0 comments Download
D test/mjsunit/es6/debug-promises/async-task-event.js View 1 chunk +0 lines, -63 lines 0 comments Download
D test/mjsunit/es6/debug-promises/evaluate-across-microtasks.js View 1 chunk +0 lines, -66 lines 0 comments Download
D test/mjsunit/es6/debug-promises/stepin-constructor.js View 1 chunk +0 lines, -47 lines 0 comments Download
D test/mjsunit/es6/debug-step-destructuring-assignment.js View 1 chunk +0 lines, -85 lines 0 comments Download
D test/mjsunit/es6/debug-step-destructuring-bind.js View 1 chunk +0 lines, -110 lines 0 comments Download
D test/mjsunit/es6/debug-step-into-class-extends.js View 1 chunk +0 lines, -42 lines 0 comments Download
D test/mjsunit/es6/debug-step-into-constructor.js View 1 chunk +0 lines, -118 lines 0 comments Download
D test/mjsunit/es6/debug-step-into-regexp-subclass.js View 1 chunk +0 lines, -36 lines 0 comments Download
D test/mjsunit/es6/debug-stepin-collections-foreach.js View 1 chunk +0 lines, -100 lines 0 comments Download
D test/mjsunit/es6/debug-stepin-generators.js View 1 chunk +0 lines, -45 lines 0 comments Download
D test/mjsunit/es6/debug-stepin-tailcalls.js View 1 chunk +0 lines, -46 lines 0 comments Download
D test/mjsunit/es6/debug-stepout-tailcalls.js View 1 chunk +0 lines, -45 lines 0 comments Download
D test/mjsunit/es6/generators-relocation.js View 1 chunk +0 lines, -61 lines 0 comments Download
D test/mjsunit/for-in-opt.js View 1 chunk +0 lines, -157 lines 0 comments Download
D test/mjsunit/harmony/async-debug-basic.js View 1 chunk +0 lines, -40 lines 0 comments Download
D test/mjsunit/harmony/async-debug-step-abort-at-break.js View 1 chunk +0 lines, -55 lines 0 comments Download
D test/mjsunit/harmony/async-debug-step-in-out-out.js View 1 chunk +0 lines, -51 lines 0 comments Download
D test/mjsunit/harmony/async-debug-step-out.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/mjsunit/harmony/debug-async-break.js View 1 chunk +0 lines, -76 lines 0 comments Download
D test/mjsunit/harmony/debug-async-break-on-stack.js View 1 chunk +0 lines, -78 lines 0 comments Download
D test/mjsunit/ignition/debug-break.js View 1 chunk +0 lines, -46 lines 0 comments Download
D test/mjsunit/ignition/debug-break-on-stack.js View 1 chunk +0 lines, -48 lines 0 comments Download
D test/mjsunit/ignition/debug-scope-on-return.js View 1 chunk +0 lines, -31 lines 0 comments Download
D test/mjsunit/ignition/debugger-statement.js View 1 chunk +0 lines, -31 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/regress/debug-prepare-step-in.js View 1 chunk +0 lines, -56 lines 0 comments Download
D test/mjsunit/regress/regress-147497.js View 1 chunk +0 lines, -45 lines 0 comments Download
D test/mjsunit/regress/regress-1523.js View 1 chunk +0 lines, -69 lines 0 comments Download
D test/mjsunit/regress/regress-269.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/mjsunit/regress/regress-2825.js View 1 chunk +0 lines, -40 lines 0 comments Download
D test/mjsunit/regress/regress-3717.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/mjsunit/regress/regress-392114.js View 1 chunk +0 lines, -66 lines 0 comments Download
D test/mjsunit/regress/regress-4320.js View 1 chunk +0 lines, -21 lines 0 comments Download
D test/mjsunit/regress/regress-491536.js View 1 chunk +0 lines, -10 lines 0 comments Download
D test/mjsunit/regress/regress-514362.js View 1 chunk +0 lines, -21 lines 0 comments Download
D test/mjsunit/regress/regress-5279.js View 1 chunk +0 lines, -16 lines 0 comments Download
D test/mjsunit/regress/regress-5559.js View 1 chunk +0 lines, -38 lines 0 comments Download
D test/mjsunit/regress/regress-617882.js View 1 chunk +0 lines, -29 lines 0 comments Download
D test/mjsunit/regress/regress-94873.js View 1 chunk +0 lines, -78 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-387599.js View 1 chunk +0 lines, -17 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-405491.js View 1 chunk +0 lines, -5 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-405922.js View 1 chunk +0 lines, -30 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-409614.js View 1 chunk +0 lines, -37 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-568477-1.js View 1 chunk +0 lines, -54 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-568477-3.js View 1 chunk +0 lines, -56 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-568477-4.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-582048.js View 1 chunk +0 lines, -31 lines 0 comments Download
D test/mjsunit/regress/regress-debug-code-recompilation.js View 1 chunk +0 lines, -51 lines 0 comments Download
D test/mjsunit/regress/regress-debug-context-load.js View 1 chunk +0 lines, -8 lines 0 comments Download
D test/mjsunit/wasm/asm-debug.js View 1 chunk +0 lines, -89 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 36 (26 generated)
jgruber
4 years, 1 month ago (2016-11-07 14:30:43 UTC) #10
Yang
very nice. lgtm.
4 years, 1 month ago (2016-11-07 14:32:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480223002/20001
4 years, 1 month ago (2016-11-07 14:56:01 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 14:58:20 UTC) #14
jgruber
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2480283002/ by jgruber@chromium.org. ...
4 years, 1 month ago (2016-11-07 15:10:43 UTC) #15
rmistry
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2476303003/ by rmistry@google.com. ...
4 years, 1 month ago (2016-11-07 15:48:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480223002/80001
4 years, 1 month ago (2016-11-08 10:36:09 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-08 10:38:50 UTC) #32
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/9e07e0005dffed298e883da6c0de6e01ce3ab80b Cr-Commit-Position: refs/heads/master@{#40804}
4 years, 1 month ago (2016-11-17 22:24:48 UTC) #34
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:43 UTC) #36
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/60d60fd716033ad47715019393195a12b19642c6
Cr-Commit-Position: refs/heads/master@{#40824}

Powered by Google App Engine
This is Rietveld 408576698