Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/pdfium.py

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/win_goma_disabled.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/pdfium.py
diff --git a/scripts/slave/recipes/pdfium.py b/scripts/slave/recipes/pdfium.py
index 8d2bb7e7ef6b78ebeee021731119c36d04f20f34..874b9a4803a44a6cfbca37562869cd6e04334863 100644
--- a/scripts/slave/recipes/pdfium.py
+++ b/scripts/slave/recipes/pdfium.py
@@ -97,11 +97,11 @@ def _BuildSteps(api, clang, out_dir):
ninja_cmd = ['ninja', '-C', debug_path,
'-j', api.goma.recommended_goma_jobs]
- with api.goma.build_with_goma(
+ api.goma.build_with_goma(
+ name='compile with ninja',
+ ninja_command=ninja_cmd,
ninja_log_outdir=debug_path,
- ninja_log_compiler='clang' if clang else 'unknown',
- ninja_log_command=ninja_cmd):
- api.step('compile with ninja', ninja_cmd)
+ ninja_log_compiler='clang' if clang else 'unknown')
def _RunTests(api, memory_tool, v8, out_dir):
« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/win_goma_disabled.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698