Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: scripts/slave/recipes/pdfium.py

Issue 2480193002: Stop to use contextmanager for goma.build_with_goma (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/win_goma_disabled.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'depot_tools/bot_update', 6 'depot_tools/bot_update',
7 'depot_tools/depot_tools', 7 'depot_tools/depot_tools',
8 'depot_tools/gclient', 8 'depot_tools/gclient',
9 'goma', 9 'goma',
10 'recipe_engine/path', 10 'recipe_engine/path',
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 '--args=' + ' '.join(args)], 90 '--args=' + ' '.join(args)],
91 cwd=checkout) 91 cwd=checkout)
92 92
93 93
94 def _BuildSteps(api, clang, out_dir): 94 def _BuildSteps(api, clang, out_dir):
95 # Build sample file using Ninja 95 # Build sample file using Ninja
96 debug_path = api.path['checkout'].join('out', out_dir) 96 debug_path = api.path['checkout'].join('out', out_dir)
97 ninja_cmd = ['ninja', '-C', debug_path, 97 ninja_cmd = ['ninja', '-C', debug_path,
98 '-j', api.goma.recommended_goma_jobs] 98 '-j', api.goma.recommended_goma_jobs]
99 99
100 with api.goma.build_with_goma( 100 api.goma.build_with_goma(
101 name='compile with ninja',
102 ninja_command=ninja_cmd,
101 ninja_log_outdir=debug_path, 103 ninja_log_outdir=debug_path,
102 ninja_log_compiler='clang' if clang else 'unknown', 104 ninja_log_compiler='clang' if clang else 'unknown')
103 ninja_log_command=ninja_cmd):
104 api.step('compile with ninja', ninja_cmd)
105 105
106 106
107 def _RunTests(api, memory_tool, v8, out_dir): 107 def _RunTests(api, memory_tool, v8, out_dir):
108 env = {} 108 env = {}
109 if memory_tool == 'asan': 109 if memory_tool == 'asan':
110 options = ['detect_leaks=1', 110 options = ['detect_leaks=1',
111 'allocator_may_return_null=1', 111 'allocator_may_return_null=1',
112 'symbolize=1', 112 'symbolize=1',
113 'external_symbolizer_path=' 113 'external_symbolizer_path='
114 'third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer'] 114 'third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer']
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 364
365 yield ( 365 yield (
366 api.test('android') + 366 api.test('android') +
367 api.platform('linux', 64) + 367 api.platform('linux', 64) +
368 api.properties(mastername='client.pdfium', 368 api.properties(mastername='client.pdfium',
369 buildername='android', 369 buildername='android',
370 slavename='test_slave', 370 slavename='test_slave',
371 target_os='android', 371 target_os='android',
372 skip_test=True) 372 skip_test=True)
373 ) 373 )
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/win_goma_disabled.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698