Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2480123002: Prevent Escape key from closing open file dialog when Quick View is opening. (Closed)

Created:
4 years, 1 month ago by oka
Modified:
4 years, 1 month ago
Reviewers:
yamaguchi
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent Escape key from closing open file dialog when Quick View is opening. TEST=manually. BUG=658745 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4ef31bd8ba19d23fa815ae76dcedaa9b77751d72 Cr-Commit-Position: refs/heads/master@{#430900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
oka
PTAL.
4 years, 1 month ago (2016-11-07 01:38:49 UTC) #3
yamaguchi
lgtm
4 years, 1 month ago (2016-11-07 02:17:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480123002/1
4 years, 1 month ago (2016-11-09 08:49:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 09:15:45 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 09:17:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ef31bd8ba19d23fa815ae76dcedaa9b77751d72
Cr-Commit-Position: refs/heads/master@{#430900}

Powered by Google App Engine
This is Rietveld 408576698