ui/file_manager/file_manager/foreground/js/quick_view_controller.js - Issue 2480123002: Prevent Escape key from closing open file dialog when Quick View is opening.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Issue 2480123002: Prevent Escape key from closing open file dialog when Quick View is opening. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/foreground/js/quick_view_controller.js

diff --git a/ui/file_manager/file_manager/foreground/js/quick_view_controller.js b/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

index 6d57dadbc67e0407c65c032e34afcf77d5df003f..2b04daada9f5b5e3c15c499e855c4ef425958f2b 100644

--- a/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

+++ b/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

@@ -126,6 +126,8 @@ QuickViewController.prototype.onQuickViewKeyDown_ = function(event) {

case ' ':

case 'Escape':

event.preventDefault();

+ // Prevent the open dialog from closing.

+ event.stopImmediatePropagation();

this.quickView_.close();

break;

case 'ArrowRight':

« no previous file with comments | « no previous file | no next file » | no next file with comments »