Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2480023002: mus: Remove unnecessary GpuMemoryBuffer code from client-lib. (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years, 1 month ago
Reviewers:
reveman, sky
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Remove unnecessary GpuMemoryBuffer code from client-lib. The gfx::GpuMemoryBuffer implementations in the mus client lib do not do the right thing, and are not really necessary. Remove the code, and instead use the same implementation in gpu-client that content uses. The code is still not right: instead of getting memory buffer from the host, the code allocates shared memory on the client side. When returning memory, the code ignores the sync token. These issues will be fixed in future CLs. BUG=643746 Committed: https://crrev.com/537e5ca6e3115aace06a3573aaa29b33345363c5 Cr-Commit-Position: refs/heads/master@{#430335}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -311 lines) Patch
M services/ui/public/cpp/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D services/ui/public/cpp/gpu_memory_buffer_impl.h View 1 chunk +0 lines, -60 lines 0 comments Download
D services/ui/public/cpp/gpu_memory_buffer_impl.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D services/ui/public/cpp/mojo_gpu_memory_buffer.h View 1 chunk +0 lines, -61 lines 0 comments Download
D services/ui/public/cpp/mojo_gpu_memory_buffer.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M services/ui/public/cpp/mojo_gpu_memory_buffer_manager.h View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc View 1 2 2 chunks +55 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (14 generated)
sadrul
4 years, 1 month ago (2016-11-05 07:09:51 UTC) #10
reveman
lgtm
4 years, 1 month ago (2016-11-05 19:49:40 UTC) #13
sadrul
+sky for owner review. /cc +piman FYI
4 years, 1 month ago (2016-11-05 23:15:00 UTC) #15
sky
LGTM
4 years, 1 month ago (2016-11-07 16:39:39 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480023002/40001
4 years, 1 month ago (2016-11-07 17:42:41 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-07 19:04:22 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:15:37 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/537e5ca6e3115aace06a3573aaa29b33345363c5
Cr-Commit-Position: refs/heads/master@{#430335}

Powered by Google App Engine
This is Rietveld 408576698