Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2479043002: mus: Get the gpu memory buffer from the window server. (Closed)

Created:
4 years, 1 month ago by sadrul
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez, reveman, sky
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, rjkroege, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Get the gpu memory buffer from the window server. Instead of allocating shared memory on the client side, allocate it from the gpu host (i.e. the window server). The window server still isn't complete: it currently always allocates shared memory. In subsequent CLs, the window server will be updated to allocate native gpu memory throug mus-gpu. BUG=643746 Committed: https://crrev.com/4f2b76d28896df4fc12d768eb1d9a5c7a9602211 Cr-Commit-Position: refs/heads/master@{#430833}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -43 lines) Patch
M services/ui/public/cpp/gpu_service.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M services/ui/public/cpp/mojo_gpu_memory_buffer_manager.h View 1 2 chunks +27 lines, -2 lines 0 comments Download
M services/ui/public/cpp/mojo_gpu_memory_buffer_manager.cc View 1 2 chunks +79 lines, -31 lines 0 comments Download
M services/ui/public/interfaces/gpu_service.mojom View 1 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/gpu_service_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/gpu_service_proxy.cc View 1 2 chunks +47 lines, -3 lines 1 comment Download
M ui/gfx/mojo/buffer_types_traits.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (15 generated)
sadrul
tsepez@ for the mojom and struct-traits change. reveman@ for the rest of the changes.
4 years, 1 month ago (2016-11-08 04:56:07 UTC) #11
Tom Sepez
lgtm
4 years, 1 month ago (2016-11-08 18:28:03 UTC) #14
reveman
lgtm https://codereview.chromium.org/2479043002/diff/60001/services/ui/ws/gpu_service_proxy.cc File services/ui/ws/gpu_service_proxy.cc (right): https://codereview.chromium.org/2479043002/diff/60001/services/ui/ws/gpu_service_proxy.cc#newcode151 services/ui/ws/gpu_service_proxy.cc:151: const gpu::SyncToken& sync_token) { fyi: this sync_token is ...
4 years, 1 month ago (2016-11-08 19:46:46 UTC) #15
sadrul
+sky@ for owner review. /cc +piman@ FYI
4 years, 1 month ago (2016-11-08 20:18:48 UTC) #17
sky
LGTM
4 years, 1 month ago (2016-11-08 23:51:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479043002/60001
4 years, 1 month ago (2016-11-09 02:22:19 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 1 month ago (2016-11-09 02:30:14 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 02:33:44 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f2b76d28896df4fc12d768eb1d9a5c7a9602211
Cr-Commit-Position: refs/heads/master@{#430833}

Powered by Google App Engine
This is Rietveld 408576698