Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2479943002: DevTools: Don't show autocomplete when the user is typing a number (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't show autocomplete when the user is typing a number Any time the user typed 3, we would show a suggestion for Float32Array. BUG=660941 Committed: https://crrev.com/1a7fe92e0e53bd505ef6893a6d148f50d144db4a Cr-Commit-Position: refs/heads/master@{#430157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions.html View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
einbinder
ptal
4 years, 1 month ago (2016-11-04 22:40:02 UTC) #3
lushnikov
lgtm
4 years, 1 month ago (2016-11-05 02:55:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479943002/1
4 years, 1 month ago (2016-11-05 07:52:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 07:57:54 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 07:59:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a7fe92e0e53bd505ef6893a6d148f50d144db4a
Cr-Commit-Position: refs/heads/master@{#430157}

Powered by Google App Engine
This is Rietveld 408576698