third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js - Issue 2479943002: DevTools: Don't show autocomplete when the user is typing a number

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

Issue 2479943002: DevTools: Don't show autocomplete when the user is typing a number (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js b/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

index 044f0709b5fc225f4fecf7fdfbbb7ab11a4576a4..c53a7e7d6a82f3c03b22217a941d142bb091c674 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/JavaScriptAutocomplete.js

@@ -74,7 +74,7 @@ WebInspector.JavaScriptAutocomplete.completionsForExpression = function(expressi

expressionString = expressionString.substr(0, lastIndex);

// User is entering float value, do not suggest anything.

- if (expressionString && !isNaN(expressionString))

+ if ((expressionString && !isNaN(expressionString)) || (!expressionString && query && !isNaN(query)))

return Promise.resolve([]);

if (!query && !expressionString && !force)

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-correct-suggestions-expected.txt ('k') | no next file » | no next file with comments »