Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/unittests/BUILD.gn

Issue 2479863002: Add icu libraries to unittests dependencies (Closed)
Patch Set: Check only i18n flag and fix gn Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gni/v8.gni ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/BUILD.gn
diff --git a/test/unittests/BUILD.gn b/test/unittests/BUILD.gn
index c005b144f0fc6ba14e16f00362026bbfcbde9c1d..d97d54f0051a08e9814556d98f545e83981a8a3b 100644
--- a/test/unittests/BUILD.gn
+++ b/test/unittests/BUILD.gn
@@ -170,6 +170,10 @@ v8_executable("unittests") {
"//testing/gtest",
]
+ if (v8_enable_i18n_support) {
+ deps += [ "//third_party/icu" ]
+ }
+
if (is_win) {
# This warning is benignly triggered by the U16 and U32 macros in
# bytecode-utils.h.
« no previous file with comments | « gni/v8.gni ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698