Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 247983003: Revert of make drawText calls non-virtual, to ease SkFont and TextBlob (Closed)

Created:
6 years, 8 months ago by reed1
Modified:
6 years, 8 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/) Reason for revert: need to test more the code-path where we don't opt into the new virtuals Original issue's description: > make drawText calls non-virtual, to ease SkFont and TextBlob > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14307 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -242 lines) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkCanvas.h View 6 chunks +4 lines, -27 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 2 chunks +13 lines, -9 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 2 chunks +10 lines, -8 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 2 chunks +10 lines, -8 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 2 chunks +10 lines, -8 lines 0 comments Download
M include/utils/SkProxyCanvas.h View 2 chunks +10 lines, -8 lines 0 comments Download
M src/core/SkBBoxRecord.h View 3 chunks +10 lines, -8 lines 0 comments Download
M src/core/SkBBoxRecord.cpp View 6 chunks +15 lines, -14 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +19 lines, -35 lines 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +9 lines, -9 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 4 chunks +12 lines, -8 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 6 chunks +20 lines, -16 lines 0 comments Download
M src/record/SkRecorder.h View 2 chunks +19 lines, -19 lines 0 comments Download
M src/record/SkRecorder.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +11 lines, -8 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 3 chunks +10 lines, -8 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 chunk +10 lines, -8 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +10 lines, -8 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +10 lines, -8 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +14 lines, -8 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of make drawText calls non-virtual, to ease SkFont and TextBlob
6 years, 8 months ago (2014-04-22 20:06:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/247983003/1
6 years, 8 months ago (2014-04-22 20:06:56 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 20:07:53 UTC) #3
Message was sent while issue was closed.
Change committed as 14314

Powered by Google App Engine
This is Rietveld 408576698