Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2479813003: Remove outdated interface tests which were hidden by promise_test behaviour. (Closed)

Created:
4 years, 1 month ago by harkness
Modified:
4 years, 1 month ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove outdated interface tests which were hidden by promise_test behaviour. A recent change to testharness.js (https://codereview.chromium.org/2468053002) causes promise_test to throw a TypeError exception when the test returns something other than a promise. Previously, the test could hide test failures if the asynchronous test failures resolved after the default promise created by promise_test. The change to promise_test behaviour caused the budget service's interface.html test to start failing because it did not return a promise, but it also exposed the root problem that outdated code should have been failing already. This CL removes the interfaces-expected.txt which reported the promise_test misuse, and also removes the outdated code. BUG=662172 Committed: https://crrev.com/af2af12b8a17d3176148b15ce17e5236879ae60a Cr-Commit-Position: refs/heads/master@{#429907}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -29 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html View 1 chunk +1 line, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/budget/interfaces-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
harkness
4 years, 1 month ago (2016-11-04 15:03:32 UTC) #2
Peter Beverloo
lgtm
4 years, 1 month ago (2016-11-04 15:11:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479813003/1
4 years, 1 month ago (2016-11-04 16:12:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 16:17:35 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 16:41:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af2af12b8a17d3176148b15ce17e5236879ae60a
Cr-Commit-Position: refs/heads/master@{#429907}

Powered by Google App Engine
This is Rietveld 408576698