Issue 2479743003: Don't call CloseBubble multiple times in ExtensionInstalledBubbleView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2479743003: Don't call CloseBubble multiple times in ExtensionInstalledBubbleView (Closed)

Created:
4 years, 1 month ago by Evan Stade

Modified:
4 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't call CloseBubble multiple times in ExtensionInstalledBubbleView fixes crashes on clicking "manage extensions" or "sign in to chrome" BUG=661096 Review-Url: https://codereview.chromium.org/2468873003 Cr-Commit-Position: refs/heads/master@{#429912} (cherry picked from commit 5d800ae3299fcbda1e0d9111aa83ae707c2c2fb6)

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

4 years, 1 month ago (2016-11-04 23:15:34 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
1ee330dc6991e387c113574de6ee3d1812e03dfb.

Expand Messages | Collapse Messages