Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 2479743003: Don't call CloseBubble multiple times in ExtensionInstalledBubbleView (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
index 85331a2314e33042bda8588e73a22e6ae9e7ca33..8125e675d128e24d888e9d636f9e8bd14f929f5d 100644
--- a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
@@ -260,7 +260,8 @@ void ExtensionInstalledBubbleView::OnSignInLinkClicked() {
chrome::ShowBrowserSignin(
browser(),
signin_metrics::AccessPoint::ACCESS_POINT_EXTENSION_INSTALL_BUBBLE);
- CloseBubble();
+ // Showing the sign-in UI will cause the bubble to close.
+ CHECK(GetWidget()->IsClosed());
}
void ExtensionInstalledBubbleView::LinkClicked(views::Link* source,
@@ -272,7 +273,8 @@ void ExtensionInstalledBubbleView::LinkClicked(views::Link* source,
chrome::NavigateParams params(
chrome::GetSingletonTabNavigateParams(browser(), GURL(configure_url)));
chrome::Navigate(&params);
- CloseBubble();
+ // Navigating will cause the bubble to close.
+ CHECK(GetWidget()->IsClosed());
}
gfx::Size ExtensionInstalledBubbleView::GetIconSize() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698