chrome/browser/component_updater/subresource_filter_component_installer.h - Issue 2479633003: Makes the component installers return a Result instead of a bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/subresource_filter_component_installer.h

Issue 2479633003: Makes the component installers return a Result instead of a bool. (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/sth_set_component_installer.cc ('k') | chrome/browser/component_updater/subresource_filter_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/subresource_filter_component_installer.h

diff --git a/chrome/browser/component_updater/subresource_filter_component_installer.h b/chrome/browser/component_updater/subresource_filter_component_installer.h

index dcc8e6daf9f77b595b508c4860f04471eff9691f..e9d5ade7ccfa6a5a0c0145cdbb25043b9d909956 100644

--- a/chrome/browser/component_updater/subresource_filter_component_installer.h

+++ b/chrome/browser/component_updater/subresource_filter_component_installer.h

@@ -34,8 +34,9 @@ class SubresourceFilterComponentInstallerTraits

// ComponentInstallerTraits implementation.

bool SupportsGroupPolicyEnabledComponentUpdates() const override;

bool RequiresNetworkEncryption() const override;

- bool OnCustomInstall(const base::DictionaryValue& manifest,

- const base::FilePath& install_dir) override;

+ update_client::CrxInstaller::Result OnCustomInstall(

+ const base::DictionaryValue& manifest,

+ const base::FilePath& install_dir) override;

bool VerifyInstallation(const base::DictionaryValue& manifest,

const base::FilePath& install_dir) const override;

void ComponentReady(const base::Version& version,