chrome/browser/component_updater/subresource_filter_component_installer.cc - Issue 2479633003: Makes the component installers return a Result instead of a bool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/subresource_filter_component_installer.cc

Issue 2479633003: Makes the component installers return a Result instead of a bool. (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/subresource_filter_component_installer.h ('k') | chrome/browser/component_updater/supervised_user_whitelist_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/subresource_filter_component_installer.cc

diff --git a/chrome/browser/component_updater/subresource_filter_component_installer.cc b/chrome/browser/component_updater/subresource_filter_component_installer.cc

index 57db6ed2edd304581b7e636aa133fa7fb5de4020..8646899a3dc41a3a7b4388f502b6b019b42639f3 100644

--- a/chrome/browser/component_updater/subresource_filter_component_installer.cc

+++ b/chrome/browser/component_updater/subresource_filter_component_installer.cc

@@ -80,10 +80,11 @@ bool SubresourceFilterComponentInstallerTraits::RequiresNetworkEncryption()

return false;

}

-bool SubresourceFilterComponentInstallerTraits::OnCustomInstall(

+update_client::CrxInstaller::Result

+SubresourceFilterComponentInstallerTraits::OnCustomInstall(

const base::DictionaryValue& manifest,

const base::FilePath& install_dir) {

- return true; // Nothing custom here.

+ return update_client::CrxInstaller::Result(0); // Nothing custom here.

}

void SubresourceFilterComponentInstallerTraits::ComponentReady(