Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2479523002: [ic] Avoid extra prototype chain iteration when creating a load IC data handler. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Avoid extra prototype chain iteration when creating a load IC data handler. Since all possible data-encoded prototype chain checks are supported by LoadIC we can remove this extra iteration. LoadGlobalIC does not support data handlers yet. BUG=v8:5561 Committed: https://crrev.com/2010ac0c7d13d3211f071bacd1a5a7ba5c6abc41 Cr-Commit-Position: refs/heads/master@{#40738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M src/ic/ic.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/ic/ic.cc View 5 chunks +11 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-03 12:50:09 UTC) #5
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-03 13:17:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479523002/1
4 years, 1 month ago (2016-11-03 17:50:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 17:52:22 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:21:19 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2010ac0c7d13d3211f071bacd1a5a7ba5c6abc41
Cr-Commit-Position: refs/heads/master@{#40738}

Powered by Google App Engine
This is Rietveld 408576698