[ic] Data handlers for loads of non-existent properties.

[ic] Data handlers for loads of non-existent properties.

BUG=v8:5561
Committed: https://crrev.com/9377226a7309662ae81a52614cb43d350563242a
Cr-Commit-Position: refs/heads/master@{#40735}

[Igor Sheludko, 2016-11-02 22:03:54]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 22:04:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-02 22:29:49]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 22:29:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:54:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 22:54:38]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-11-03 08:37:35]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-11-03 08:38:34]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-11-03 08:38:35]

PTAL

[Igor Sheludko, 2016-11-03 08:39:06]

Description was changed from

==========
[ic] Data handlers for load of non-existent properties.

BUG=v8:5561
==========

to

==========
[ic] Data handlers for loads of non-existent properties.

BUG=v8:5561
==========

[Jakob Kummerow, 2016-11-03 13:03:41]

lgtm

https://codereview.chromium.org/2471613006/diff/20001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/2471613006/diff/20001/src/ic/ic.cc#newcode959
src/ic/ic.cc:959: if (receiver_map->IsJSGlobalObjectMap()) {
You mean DCHECK(!receiver_map->IsJSGlobalObjectMap()) ?

[Igor Sheludko, 2016-11-03 16:14:39]

https://codereview.chromium.org/2471613006/diff/20001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/2471613006/diff/20001/src/ic/ic.cc#newcode959
src/ic/ic.cc:959: if (receiver_map->IsJSGlobalObjectMap()) {
On 2016/11/03 13:03:40, Jakob Kummerow wrote:
> You mean DCHECK(!receiver_map->IsJSGlobalObjectMap()) ?

Indeed.

[Igor Sheludko, 2016-11-03 16:14:47]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-11-03 16:14:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2471613006/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-11-03 16:14:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 17:14:57]

Description was changed from

==========
[ic] Data handlers for loads of non-existent properties.

BUG=v8:5561
==========

to

==========
[ic] Data handlers for loads of non-existent properties.

BUG=v8:5561
==========

[commit-bot: I haz the power, 2016-11-03 17:14:58]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:21:07]

Description was changed from

==========
[ic] Data handlers for loads of non-existent properties.

BUG=v8:5561
==========

to

==========
[ic] Data handlers for loads of non-existent properties.

BUG=v8:5561

Committed: https://crrev.com/9377226a7309662ae81a52614cb43d350563242a
Cr-Commit-Position: refs/heads/master@{#40735}
==========

[commit-bot: I haz the power, 2016-11-17 22:21:08]

Patchset 2 (id:??) landed as
https://crrev.com/9377226a7309662ae81a52614cb43d350563242a
Cr-Commit-Position: refs/heads/master@{#40735}